[Webkit-unassigned] [Bug 33287] PNGEncoder.cpp lacks support for libpng 1.4

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33287


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54696|review?                     |review-
               Flag|                            |




--- Comment #4 from Jeremy Orlow <jorlow at chromium.org>  2010-04-29 07:08:54 PST ---
(From update of attachment 54696)
This change log would be more standard.  Note the moved url.

"""
2010-04-29  Paweł Hajdan, Jr.  <phajdan.jr at chromium.org>

        Reviewed by NOBODY (OOPS!).

        Fix building with libpng-1.4.
        https://bugs.webkit.org/show_bug.cgi?id=33287

        No new tests (no behavior change).

        Original patch by John Bowler <jbowler at acm.org>

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode):
"""


>      png_struct* pngPtr = png_create_write_struct(PNG_LIBPNG_VER_STRING,
> -                                                 png_voidp_NULL,
> -                                                 png_error_ptr_NULL,
> -                                                 png_error_ptr_NULL);
> +                                                 0,
> +                                                 0,
> +                                                 0);

Put all of these values on one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.