[Webkit-unassigned] [Bug 38280] Fix spanning branch instruction on Cortex-A8 with Thumb-2 JIT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 29 00:57:48 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38280





--- Comment #3 from Gabor Loki <loki at webkit.org>  2010-04-29 00:57:48 PST ---
> I think there is a bug in this calculation.

Ops, you are right. I am going to fix this.

>     // The instruction is spanning two pages if it ends at an address ending
> 0x002.
>     bool spansTwo4K = (reinterpret_cast<intptr_t>(instruction) & 0xfff) ==
> 0x002;
>     // The target is in the first page if the jump branch back back by
> [3..0x1002] bytes.  (only if spansTwo4K is true)
>     bool targetInFirstPage = (relative >= -0x1002) && (relative < -2);
>     bool wouldTriggerA8Errata = spansTwo4K && targetInFirstPage;

This looks better. Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list