[Webkit-unassigned] [Bug 38286] Need to call FrameView::scrollPositionChanged when changing the scroll position when the ScrollView does not have a platformWidget

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38286





--- Comment #10 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-04-29 00:50:04 PST ---
(From update of attachment 54648)
>      scrollContents(scrollDelta);
> +    scrollPositionChanged();

For my follow up patch, it would be better if those calls could be the other
way around:
+    scrollPositionChanged();
     scrollContents(scrollDelta);
So all the positions are valid in the code of scrollContents() and I can use
the repaint rects to implement 33150.


>  void ScrollView::scrollRectIntoViewRecursively(const IntRect& r)
> @@ -338,6 +339,7 @@ void ScrollView::setScrollPosition(const IntPoint& scrollPoint)
>          return;
>  
>      updateScrollbars(IntSize(newScrollPosition.x(), newScrollPosition.y()));
> +    scrollPositionChanged();
>  }

I don't think you need this call if you already call scrollPositionChanged() in
ScrollView::valueChanged(). UpdateScrollbar() will end up in
ScrollView::valueChanged(), so scrollPositionChanged() will be called twice.

Thanks again for making this patch, I go to bed with a problem, I woke up with
your patch :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.