[Webkit-unassigned] [Bug 37023] [Qt] Expose HTMLTokenizer yielding parameters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37023


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54667|review?                     |review+
               Flag|                            |




--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2010-04-29 00:36:18 PST ---
(From update of attachment 54667)
> Index: WebKit/qt/ChangeLog
> ===================================================================
> --- WebKit/qt/ChangeLog	(revision 58467)
> +++ WebKit/qt/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2010-04-28  Laszlo Gombos  <laszlo.1.gombos at nokia.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] Expose HTMLTokenizer yielding parameters
> +        https://bugs.webkit.org/show_bug.cgi?id=37023
> +
> +        Enables to set TimeDelay and ChunkSize for 
> +        HTMLTokenizer.
> +
> +        * Api/qwebpage.cpp:
> +        (QWebPagePrivate::dynamicPropertyChangeEvent):
> +
>  2010-04-28  Laszlo Gombos  <laszlo.1.gombos at nokia.com>
>  
>          Unreviewed, Qt build fix.
> Index: WebKit/qt/Api/qwebpage.cpp
> ===================================================================
> --- WebKit/qt/Api/qwebpage.cpp	(revision 58462)
> +++ WebKit/qt/Api/qwebpage.cpp	(working copy)
> @@ -1219,6 +1219,14 @@ void QWebPagePrivate::dynamicPropertyCha
>              view->forceLayout();
>          }
>      }
> +    else if (event->propertyName() == "HTMLTokenizerChunkSize") {
> +        int chunkSize = q->property("HTMLTokenizerChunkSize").toInt();
> +        q->handle()->page->setCustomHTMLTokenizerChunkSize(chunkSize);
> +    }
> +    else if (event->propertyName() == "HTMLTokenizerTimeDelay") {
> +        double timeDelay = q->property("HTMLTokenizerTimeDelay").toDouble();
> +        q->handle()->page->setCustomHTMLTokenizerTimeDelay(timeDelay);
> +    }
>  }
>  
>  void QWebPagePrivate::shortcutOverrideEvent(QKeyEvent* event)
WebKit/qt/Api/qwebpage.cpp:1222
 +      else if (event->propertyName() == "HTMLTokenizerChunkSize") {
Shouldn't the else be merged with the previous line? :)

WebKit/qt/Api/qwebpage.cpp:1230
 +  }
It would be nice to call the base implementation here, just for future
proofing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.