[Webkit-unassigned] [Bug 38304] [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38304


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54660|review?                     |review+
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-04-28 20:10:08 PST ---
(From update of attachment 54660)
> void QWEBKIT_EXPORT qt_drt_run(bool b)

I'm pretty sure this one is not used by anyone outside the DRT, does it really
make sense to reintroduce it?


WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:431
 +  bool QWEBKIT_EXPORT qt_drt_pauseAnimation(QWebFrame *qframe, const QString
&animationName, double time, const QString &elementId)
Wrong coding style, please fix before landing. Also, just use frame, not need
to call it qFrame/qframe.

I think it makes sense to order the DRT methods together and the QWebPage ones
as well; right now they are mixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.