[Webkit-unassigned] [Bug 38150] Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38150





--- Comment #8 from MORITA Hajime <morrita at google.com>  2010-04-28 19:17:38 PST ---
Hi Darin, thank you for reviewing and sorry for noisy attachments.

(In reply to comment #2)
> (From update of attachment 54364 [details])
> WebCore/html/HTMLFormControlElement.h:160
>  +      virtual void defaultEventHandler(Event*);
> This should be as private as possible. I don't see any good reason to make it
> public. Either protected or private should work. Similarly, I think
> HTMLInputElement and HTMLTextAreaElement could now have private
> defaultEventHandler functions since there is no longer anyone calling directly.
Fixed moving defaultEventHandler() declarations
from public to protected or private (based on inheritance relation)

> WebCore/rendering/TextControlInnerElements.cpp:119
>  +      if (shadowAncestor && shadowAncestor->renderer()) {
>  +          ASSERT(shadowAncestor->renderer()->isTextControl());
> We should not fetch the renderer() any more or assert that it is a text
> control.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.