[Webkit-unassigned] [Bug 38297] Webkit doesn't compile with 3D-canvas enabled and video disabled
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 28 17:52:15 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=38297
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54643|review?, commit-queue? |review-, commit-queue-
Flag| |
--- Comment #2 from Darin Adler <darin at apple.com> 2010-04-28 17:52:15 PST ---
(From update of attachment 54643)
> #include "HTMLVideoElement.h"
> #include "JSHTMLCanvasElement.h"
> #include "JSHTMLImageElement.h"
> +#if ENABLE(VIDEO)
> #include "JSHTMLVideoElement.h"
> +#endif
> #include "JSImageData.h"
> #include "JSWebGLBuffer.h"
> #include "JSWebGLFloatArray.h"
Conditional includes should go in their own paragraph, after the unconditional
ones, not sorted in the include list.
Sorry to be so picky about a minor aspect of the patch.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list