[Webkit-unassigned] [Bug 38286] Need to call FrameView::scrollPositionChanged when changing the scroll position when the ScrollView does not have a platformWidget

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 28 16:11:14 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38286


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54628|review?                     |review+
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-04-28 16:11:13 PST ---
(From update of attachment 54628)
r=me

> +    virtual void scrollPositionChanged() {}

I'd prefer that this be private. There's no need for code outside the class to
ever call this and a derived class can override a function even if it's
private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list