[Webkit-unassigned] [Bug 38284] Audit all uses of subprocess in webkitpy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38284


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54621|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2010-04-28 14:38:53 PST ---
(From update of attachment 54621)
Two things to fix up before committing.

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +        in webkitpy.  I did not find any unsafe calls
> +        in my audit, but I did remove numerousunneeded

numerousunneeded


>
> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py b/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_mac.py

> -            rcode = subprocess.call(['wdiff'], stderr=f)
> +            # We're ignoring the return and always returning True
> +            self._executive.run_command(['wdiff'], error_handler=Excutive.ignore_error)
Excutive

You mentioned possibly adding a test for this? It may be good if you could
because it would have caught this issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.