[Webkit-unassigned] [Bug 37772] WebGL rendering context does not activate unless accelerated compositing is enabled from settings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37772





--- Comment #4 from Chris Marrin <cmarrin at apple.com>  2010-04-28 13:38:15 PST ---
(From update of attachment 53861)
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 82feb24..22c8c71 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,17 @@
> +2010-04-20  Jarkko Sakkinen  <jarkko.sakkinen at tieto.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [Qt] WebGL rendering context does not activate unless accelerated compositing is enabled from settings.
> +        https://bugs.webkit.org/show_bug.cgi?id=37772
> +        
> +        Allows WebGL rendering context creation is webGLEnabled flag
> +        is true in the document settings and does not require 
> +        also acceleratedCompositing flag also to be enabled.
> +
> +        * html/HTMLCanvasElement.cpp:
> +        (WebCore::HTMLCanvasElement::getContext):
> +
>  2010-04-19  Kevin Ollivier  <kevino at theolliviers.com>
>  
>          Fix the Mac builders for now by restoring the keepAlive function.
> diff --git a/WebCore/html/HTMLCanvasElement.cpp b/WebCore/html/HTMLCanvasElement.cpp
> index ef85323..5367040 100644
> --- a/WebCore/html/HTMLCanvasElement.cpp
> +++ b/WebCore/html/HTMLCanvasElement.cpp
> @@ -145,7 +145,7 @@ CanvasRenderingContext* HTMLCanvasElement::getContext(const String& type, Canvas
>      }
>  #if ENABLE(3D_CANVAS)    
>      Settings* settings = document()->settings();
> -    if (settings && settings->webGLEnabled() && settings->acceleratedCompositingEnabled()) {
> +    if (settings && settings->webGLEnabled()) {
>          // Accept the legacy "webkit-3d" name as well as the provisional "experimental-webgl" name.
>          // Once ratified, we will also accept "webgl" as the context name.
>          if ((type == "webkit-3d") ||

The Mac implementation requires acceleratedCompositing for WebGL rendering.
It's reasonable to remove the test for acceleratedCompositing here as long as,
for the Mac platform, webGLEnabled has a test to prevent it from being true
unless acceleratedCompositing is also true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.