[Webkit-unassigned] [Bug 36785] [Qt, Gtk] Allows build-webkit script to accept custom make command as parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36785


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51971|review?                     |review-
               Flag|                            |




--- Comment #7 from Simon Hausmann <hausmann at webkit.org>  2010-04-28 12:48:04 PST ---
(From update of attachment 51971)
(In reply to comment #6)
> (In reply to comment #5)
> > When building the qtwebkit debian package with the command
> > 
> > dpkg-buildpackage -rfakeroot -j15
> > 
> > and using --makeargs=$(MAKEFLAGS) as following
> > 
> > WebKitTools/Scripts/build-webkit --qt --makeargs=$(MAKEFLAGS)
> > 
> > It does not passes the -j15 correctly to the make command. With the attached
> > patch and the following command in the debian/rules, it works as desired.
> 
> Why not fix the usage of --makeargs, instead, then? I am assuming it should
> work for your case (in fact, using -j was precisely why it got added in the
> first place).

I agree, fixing the quoting sounds like the better thing to do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.