[Webkit-unassigned] [Bug 38256] [GTK] Random failure on 'testdownload' unit test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38256





--- Comment #4 from Mario Sanchez Prada <msanchez at igalia.com>  2010-04-28 06:00:22 PST ---
(In reply to comment #2)
> Created an attachment (id=54554)
 --> (https://bugs.webkit.org/attachment.cgi?id=54554) [details]
> Make sure the set_filename function is called after handling the
> 'download-requested' signal for the asynchronous test
> [...]

Sorry for the noise in this duplicated description, and because of forgetting
to explain the reason of this one:

This second patch is related to the same issue because it could happen, with
the current code, that the set_filename () function got called too early in the
mainloop, therefore screwing the tests because the 'theDownload' global
variable wouldn't be properly set yet.

With this modification we ensure the set_filename() function gets called always
after handling the download-requested signal, therefore avoiding potential
problems.

Perhaps this patch should go along with a different bug, but I'm not completely
sure about it. if so, please let me know and I'll gladly file a new one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.