[Webkit-unassigned] [Bug 38248] webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128', )

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38248





--- Comment #7 from Fumitoshi Ukai <ukai at chromium.org>  2010-04-28 02:54:53 PST ---
(From update of attachment 54539)

>          Reviewed by Darin Adler and Eric Seidel.
> diff --git a/WebKitTools/Scripts/webkitpy/common/system/executive.py b/WebKitTools/Scripts/webkitpy/common/system/executive.py
> index 5c1d28ca6f5ae45cebaad330018bc3b6c3c6cb1e..cb29834f4c970cecd63c105a373b2626a6391002 100644
> --- a/WebKitTools/Scripts/webkitpy/common/system/executive.py
> +++ b/WebKitTools/Scripts/webkitpy/common/system/executive.py
> @@ -161,17 +161,39 @@ class Executive(object):
>          return 2
>  
>      def kill_process(self, pid):
> +        """Attempts to kill the given pid.
> +        Will fail silently if pid does not exist or insufficient permisssions."""
>          if platform.system() == "Windows":
>              # According to http://docs.python.org/library/os.html
>              # os.kill isn't available on Windows.  However, when I tried it
>              # using Cygwin, it worked fine.  We should investigate whether
>              # we need this platform specific code here.
> -            subprocess.call(('taskkill.exe', '/f', '/pid', unicode(pid)),
> -                            stdin=open(os.devnull, 'r'),
> -                            stdout=subprocess.PIPE,
> -                            stderr=subprocess.PIPE)
> +            command = ["taskkill.exe", "/f", "/pid", pid]

str(pid) or unicode(pid) ?
are we sure pid is already string?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.