[Webkit-unassigned] [Bug 38246] wdiff_text throws ScriptError because wdiff returns non-zero when files differ

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38246





--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-04-28 01:59:02 PST ---
(In reply to comment #11)
> (From update of attachment 54537 [details])
> WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:595
>  +              raise e
> I think we don't need "e" to re-raise the exception. Also, I'm not sure if we
> need this except-clause, but I guess we want to emphasize the ScriptError can
> be thrown.

You're right.  We want just "raise" as that has the magical property of not
messing up the stacktrace.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.