[Webkit-unassigned] [Bug 38246] wdiff_text throws ScriptError because wdiff returns non-zero when files differ

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38246





--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-04-28 01:16:20 PST ---
(In reply to comment #4)
> (From update of attachment 54533 [details])
> What's the benefit of a custom error handler vs putting endAfterSelection in a
> try/except block?
> 
> Unittests look great.  Should they be limited to 80 cols? (I don't remember the
> decision).

I don't think there was a decision.  Generally I wrap to 80c, except when it
hurts readability.  I can look at wrapping the expected results.

> WebKitTools/Scripts/webkitpy/layout_tests/port/base_unittest.py:73
>  +          except Exception, e:
> Can we make this exception more tightly scoped?

We could.  I didn't want the unit tests to die unexpectedly on other systems. 
I'd rather they just ignore these tests if "which wdiff" doesn't work for any
reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.