[Webkit-unassigned] [Bug 38048] Move _path_to_apache_config_file down to webkit.py

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38048





--- Comment #7 from Tor Arne Vestbø <vestbo at webkit.org>  2010-04-28 00:26:32 PST ---
(In reply to comment #4)
> (From update of attachment 54278 [details])
> This will break Chromium, since it does not inherit from webkit.py

Ouch. What's the plan there?

> Seems this should be a white-list for debian instead of a blacklist:
> +            distro =
> platform.linux_distribution(full_distribution_name=False)[0]
> +            # FIXME: This is not going to scale. We should find a better way
> to choose
> +            # which config file to use, while still supporting the major
> distributions
> +            if distro in ["SuSE", "fedora", "redhat", "centos", "mandrake",
> +                          "mandriva", "rocks", "slackware", "yellowdog",
> "turbolinux"]:
> 
> Also, seems like we need a platform abstraction instead of a port in this case.

Fully agree. The idea was to move it down to webkit.py for now, and once we see
a pattern there we can start abstracting stuff.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.