[Webkit-unassigned] [Bug 38180] Remove unneeded custom code for WebSocket.send

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38180





--- Comment #19 from Sam Weinig <sam at webkit.org>  2010-04-27 21:08:09 PST ---
(In reply to comment #12)
> > I have to agree with Alexey on this one and would add that we should aim to
> > separate cleanup from functionality change.
> 
> That's a noble aim, but more or less impossible.  The custom bindings are
> riddled with trivial mistakes.  It seems a fools errand to document that we
> don't have these specific mistakes.  There's are infinite sea of trivial
> mistakes we could have.

For my benefit, can you list some of them?

> 
> > And to reiterate, any functionality change here should be tested.
> 
> In that case, we should accept any new custom bindings code without testing all
> the trivial behaviors it has since every time we write custom bindings we
> introduce tons of subtle functionality changes.

We expect new code to be well tested, but we need to set a higher bar on
changes to existing code since it is a change in existing behavior.  For this
change in particular, it seems the correct way to go would be to remove the
number of arguments check first (with a test as we would require if that was
the only thing you wanted to do) and then auto-generate it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.