[Webkit-unassigned] [Bug 38175] Selection drag-and-drop doesn't work for input/textarea

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38175


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tkent at chromium.org




--- Comment #5 from TAMURA, Kent <tkent at chromium.org>  2010-04-27 19:11:11 PST ---
Thank you for reviewing

(In reply to comment #2)
> I don't understand the comment "No need to calculate the selection length in a
> case of selection drag-and-drop."
> - The comment doesn't say why focused() is a reliable way to detect the fact
> that selected text is being dragged within the element.
> - The comment doesn't say why setting selectionLength to 0 is a good way to
> bypass the selection check entirely.
> The main purpose of comments is to explain why the code exists. The code can
> speak for itself on *what* it does.
> 
> I am not convinced that setting selectionLength to 0 is the best way to handle
> this.

I updated the comments. I think the new comments explain them.

And I removed the existing comment "// selection() may be a pre-edit text.".  I
added it when I fixed an issue for IME, but the comment is not helpful for now
though it was helpful during the IME change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.