[Webkit-unassigned] [Bug 38213] Page up / page down moves edited content for the entire height

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38213





--- Comment #9 from Tony Chang (Google) <tony at chromium.org>  2010-04-27 18:57:26 PST ---
Thanks for the patch!  A few comments:

- This doesn't link on Mac because WebCore::SelectionController::setSelection
is in the list of exported symbols.  I think you need to update
WebCore.base.exp.
- The change to setSelection is so you can scroll to iframe so the cursor is
the first selected line.  In TextEdit on mac, I don't see that behavior.  In
TextEdit, the frame scrolls so that the cursor is in the middle.  This is
probably a platform specific behavior.
- The existing layout test doesn't really tell you how the view scrolled.  We
probably need to add a layout test to verify that we scrolled the right amount.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.