[Webkit-unassigned] [Bug 38008] [chromium] Skia needs to fade DragImages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38008


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54105|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from David Levin <levin at chromium.org>  2010-04-27 16:31:53 PST ---
(From update of attachment 54105)
r- for swapping the x and y variable names.

WebCore/platform/chromium/DragImageChromiumSkia.cpp:79
 +      for (int x = 0; x < image->height(); ++x) {
y for height and x for width would be more typical. I thought the params passed
to getaddr32 were reversed and then realized it was the naming. 

WebKit/chromium/tests/DragImageTest.cpp: 
 +      // This is not implemented, so we don't do any output validation.
And why don't we do any validation now?

WebKit/chromium/ChangeLog:9
 +          (WebCore::TEST):
This isn't really correct. It is typically the function name.

WebKit/chromium/ChangeLog:6
 +          additional tests
This feels lacking. Perhaps it would be just as well to omit this text.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.