[Webkit-unassigned] [Bug 38227] [chromium] Don't expose filesystem paths on file drop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38227


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54470|review?                     |review-
               Flag|                            |




--- Comment #3 from Jian Li <jianli at chromium.org>  2010-04-27 16:25:00 PST ---
(From update of attachment 54470)
WebCore/ChangeLog:5
 +          [Chromium] Filter out URLs with file:// scheme from text/uri-list
when dragging.
Can you update the bug title in order to be consistent with the line above.
Also, I think you could simply say "file scheme".

WebCore/platform/chromium/ClipboardChromium.cpp:170
 +                  if (protocolIs(uri, "file"))
Could you please add a comment for doing this?

WebCore/platform/chromium/ClipboardChromium.cpp:185
 +          if (!m_dataObject->url.isEmpty() &&
!m_dataObject->url.isLocalFile()) {
ditto.

WebCore/platform/chromium/ClipboardChromium.cpp:321
 +      if (m_dataObject->url.isValid() && !m_dataObject->url.isLocalFile()) {
ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.