[Webkit-unassigned] [Bug 38175] Incorrect arithmetic in InputElement::handleBeforeTextInsertedEvent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38175





--- Comment #2 from Darin Adler <darin at apple.com>  2010-04-27 13:04:19 PST ---
(From update of attachment 54411)
In what way is this "incorrect arithmetic"? Can we re-title the bug to be
clearer?

I don't understand the comment "No need to calculate the selection length in a
case of selection drag-and-drop."
- The comment doesn't say why focused() is a reliable way to detect the fact
that selected text is being dragged within the element.
- The comment doesn't say why setting selectionLength to 0 is a good way to
bypass the selection check entirely.
The main purpose of comments is to explain why the code exists. The code can
speak for itself on *what* it does.

I am not convinced that setting selectionLength to 0 is the best way to handle
this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.