[Webkit-unassigned] [Bug 38150] Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38150


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54364|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-04-27 12:47:28 PST ---
(From update of attachment 54364)
WebCore/html/HTMLFormControlElement.h:160
 +      virtual void defaultEventHandler(Event*);
This should be as private as possible. I don't see any good reason to make it
public. Either protected or private should work. Similarly, I think
HTMLInputElement and HTMLTextAreaElement could now have private
defaultEventHandler functions since there is no longer anyone calling directly.

WebCore/rendering/TextControlInnerElements.cpp:119
 +      if (shadowAncestor && shadowAncestor->renderer()) {
 +          ASSERT(shadowAncestor->renderer()->isTextControl());
We should not fetch the renderer() any more or assert that it is a text
control.

review- because I think it's worth refining this a tiny bit more, since its
entire purpose is the refactoring.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.