[Webkit-unassigned] [Bug 38209] New: commands/steps should use a tighter mock for options

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 27 11:42:48 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38209

           Summary: commands/steps should use a tighter mock for options
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: eric at webkit.org, abarth at webkit.org,
                    cjerdonek at webkit.org


[11:39am] abarth: the real issue
[11:39am] abarth: is that we use a very loose mock for options
[11:39am] abarth: the right thing to do
[11:39am] abarth: is to use a much tighter mock
[11:39am] abarth: that's an easy change
[11:40am] abarth: in commandtest.py
[11:40am] abarth: options=Mock()
[11:40am] abarth: which means we assume that every option can be read
[11:40am] abarth: when running the command
[11:40am] abarth: instead
[11:40am] abarth: we should compute which options will actually exist
[11:40am] abarth: from the |command|

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list