[Webkit-unassigned] [Bug 38188] Remove custom NodeIterator bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38188





--- Comment #6 from Adam Barth <abarth at webkit.org>  2010-04-27 10:50:18 PST ---
(In reply to comment #3)
> (From update of attachment 54402 [details])
> WebCore/bindings/scripts/CodeGeneratorJS.pm:1894
>  +          push(@implContent, $indent . "setDOMException(exec, ec);\n") if
> @{$function->raisesExceptions};
> Comments in the ChangeLog would be helpful...

Done.

> WebCore/bindings/scripts/CodeGeneratorV8.pm:2422
>  +      if ($hasScriptState) {
> Again here....

Done.

> WebCore/bindings/scripts/test/JS/JSTestObj.cpp:625
>  +      setDOMException(exec, ec);
> Is this correct to unconditionally set the dom exception?

I think so.

> WebCore/bindings/scripts/test/JS/JSTestObj.cpp:640
>  +      setDOMException(exec, ec);
> This will smash over an an existing exception on the exec it seems.  Seems
> wrong.

As discussed before, that's not how setDOMException works.

> WebCore/bindings/scripts/test/JS/JSTestObj.cpp:639
>  +      JSC::JSValue result = toJS(exec, castedThisObj->globalObject(),
> WTF::getPtr(imp->withScriptStateObjException(exec, ec)));
> This will probably cause this to actually fix isolated world bugs.  You may
> need to update test results.

We're going to fix lots of random bugs in this proces.  This didn't cause any
tests to fail AFAIK.

> WebCore/bindings/scripts/test/V8/V8TestObj.cpp: 
>  +      if (state->hadException())
> Why?  ChangeLog comment would help here.

This is left-over junk from an earlier change where I didn't re-generate the
reference files correctly.  I'll handle that in a separate commit.

> WebCore/bindings/scripts/test/V8/V8TestObj.cpp:361
>  +      EmptyScriptState state;
> Indent?

This is a different bug in the CodeGenerator.  We should fix it in a different
patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.