[Webkit-unassigned] [Bug 37203] Add layoutTestController.setPrinting()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37203





--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-04-27 10:03:54 PST ---
(From update of attachment 52730)
I think it's very confusing that it only works for dumps and not printing.

WebCore/rendering/RenderTreeAsText.cpp:635
 +      if (printContext.get())
I don't think you need the .get() here.

WebCore/rendering/RenderTreeAsText.cpp:636
 +          printContext->end();
Very sad that there is no way to have these auto-end.

WebCore/rendering/RenderTreeAsText.cpp:625
 +      if (RenderObject* o = frame->contentRenderer()) {
Having to indent here is less readable, but I understand why you did it. :(

WebCore/rendering/RenderTreeAsText.cpp:636
 +          printContext->end();
Does destructing the PrintContext auto-end it?

WebCore/rendering/RenderTreeAsText.h:43
 +      RenderAsTextInPrintingMode = 1 << 4 // Dump the tree in printing mode.
I'm not sure the "In" is necessary in this name.  But it's OK either way.

WebCore/rendering/RenderTreeAsText.cpp:619
 +          printContext->begin(pageWidthInPixels);
I'm not sure the extra parameter for the width is useful.  We should probably
just use the frame width.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.