[Webkit-unassigned] [Bug 38160] <input type="search"> with uneven padding causes text clipping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38160





--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org>  2010-04-27 09:58:00 PST ---
(In reply to comment #6)
> (From update of attachment 54381 [details])
> > +        * rendering/RenderTextControl.cpp: moved controlClipRect implementation to TextControlSingleList
> 
> s/TextControlSingleList/RenderTextControlSingleLine/

eek. That was bad.


> > +        // Center vertically like the text.
> > +        contentsRect.setY((height() - contentsRect.height()) / 2);
> 
> Have you tested this with both even and odd heights?

Yep, I tested Caps Lock with odd, even, weird padding and no padding.


> > +IntRect RenderTextControlSingleLine::controlClipRect(int tx, int ty) const
> > +{
> > +    IntRect clipRect;
> > +    if (!m_innerBlock)
> > +        clipRect = contentBoxRect();
> 
> Does this case ever get hit? Is it covered by the test? This looks just as
> wrong as the present bug.

You're correct this case doesn't get hit. controlClipRect should only get
called if hasClipRect returns true. The only direct call is in RenderBox. I've
placed ASSERTs here.


> > +    virtual IntRect controlClipRect(int tx, int ty) const;
> 
> This should be private.

Done.


> Sorry to r- again, but I don’t understand the !m_innerBlock branch of
> controlClipRect().

Don't be sorry, I appreciate good reviews like this because I always learn
something! Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.