[Webkit-unassigned] [Bug 38188] Remove custom NodeIterator bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38188


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54402|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-04-27 02:43:26 PST ---
(From update of attachment 54402)
WebCore/bindings/scripts/CodeGeneratorJS.pm:1894
 +          push(@implContent, $indent . "setDOMException(exec, ec);\n") if
@{$function->raisesExceptions};
Comments in the ChangeLog would be helpful...

WebCore/bindings/scripts/CodeGeneratorV8.pm:2422
 +      if ($hasScriptState) {
Again here....

WebCore/bindings/scripts/test/JS/JSTestObj.cpp:625
 +      setDOMException(exec, ec);
Is this correct to unconditionally set the dom exception?

WebCore/bindings/scripts/test/JS/JSTestObj.cpp:640
 +      setDOMException(exec, ec);
This will smash over an an existing exception on the exec it seems.  Seems
wrong.

WebCore/bindings/scripts/test/JS/JSTestObj.cpp:639
 +      JSC::JSValue result = toJS(exec, castedThisObj->globalObject(),
WTF::getPtr(imp->withScriptStateObjException(exec, ec)));
This will probably cause this to actually fix isolated world bugs.  You may
need to update test results.

WebCore/bindings/scripts/test/V8/V8TestObj.cpp: 
 +      if (state->hadException())
Why?  ChangeLog comment would help here.

WebCore/bindings/scripts/test/V8/V8TestObj.cpp:361
 +      EmptyScriptState state;
Indent?

I think the JSC handling of the case where the callback throws an exception
(which is left on the exec) is not handled correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.