[Webkit-unassigned] [Bug 38186] New: REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38186

           Summary: REGRESSION(r58261): webkit-patch upload does not work
                    in an SVN checkout.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mjs at apple.com


webkit-patch upload does not work in an SVN checkout. This is a regression from
r58261. It gives this error:

$ webkit-patch upload
Parsing ChangeLog: /Users/mjs/Work/src/Safari/OpenSource/WebCore/ChangeLog
Traceback (most recent call last):
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkit-patch", line
56, in <module>
    main()
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkit-patch", line
51, in main
    WebKitPatch(__file__).main()
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py",
line 302, in main
    result = command.check_arguments_and_execute(options, args, self)
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py",
line 113, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py",
line 43, in execute
    self._sequence.run_and_handle_errors(tool, options,
self._prepare_state(options, args, tool))
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py",
line 66, in run_and_handle_errors
    self._run(tool, options, state)
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py",
line 60, in _run
    step(tool, options).run(state)
  File
"/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/steps/checkstyle.py",
line 56, in run
    if self._tool.scm().should_squash(self._options.squash):
AttributeError: SVN instance has no attribute 'should_squash'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.