[Webkit-unassigned] [Bug 38177] Add specialized thunks for a char code related string functions

Tue Apr 27 00:14:35 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=38177

Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54389|review?                     |review+
               Flag|                            |

--- Comment #2 from Maciej Stachowiak <mjs at apple.com>  2010-04-27 00:14:35 PST ---
(From update of attachment 54389)
JavaScriptCore/ChangeLog:17
 +          (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
I know this comment is a bit late, but I think the term "thunk" for these
doesn't match standard usage. Doesn't match any of the definitions here:
http://en.wikipedia.org/wiki/Thunk
I can't think of an accurate but brief term offhand. Maybe "Stub", though we
also have JIT stubs.

Patch otherwise looks correct. Please double-check that there is really a perf
gain, if so, r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.