[Webkit-unassigned] [Bug 38160] <input type="search"> with uneven padding causes text clipping

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38160


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54381|review?                     |review-
               Flag|                            |




--- Comment #6 from mitz at webkit.org  2010-04-26 22:50:11 PST ---
(From update of attachment 54381)
> +        * rendering/RenderTextControl.cpp: moved controlClipRect implementation to TextControlSingleList

s/TextControlSingleList/RenderTextControlSingleLine/


> +        // Center vertically like the text.
> +        contentsRect.setY((height() - contentsRect.height()) / 2);
> +

Have you tested this with both even and odd heights?

> +IntRect RenderTextControlSingleLine::controlClipRect(int tx, int ty) const
> +{
> +    IntRect clipRect;
> +    if (!m_innerBlock)
> +        clipRect = contentBoxRect();

Does this case ever get hit? Is it covered by the test? This looks just as
wrong as the present bug.

> +    virtual IntRect controlClipRect(int tx, int ty) const;

This should be private.

Sorry to r- again, but I don’t understand the !m_innerBlock branch of
controlClipRect().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.