[Webkit-unassigned] [Bug 38167] Add testing infrastructure for JSC bindings generator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38167


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54379|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-04-26 21:42:12 PST ---
(From update of attachment 54379)
WebCore/ChangeLog:67
 +          * bindings/scripts/test/V8/V8TestObj.cpp: Renamed from
WebCore/bindings/scripts/test/V8TestObj.cpp.
It's unclear to me why these moved from v8/test to test/v8.  Seems slightly
silly.

WebCore/bindings/scripts/test/JS/JSTestObj.cpp:6
 +      modify it under the terms of the GNU Library General Public
Why are we generating LGPL code?  Also seems silly.  But that's something to
fix later.

WebKitTools/Scripts/run-bindings-tests:46
 +             # place holder for defines (generate-bindings.pl requirement)
This comment is no longer valid.

WebKitTools/Scripts/run-bindings-tests:118
 +          # FIXME: Add ObjC
COM too?  Or did we kill COM?

WebKitTools/Scripts/run-bindings-tests:123
 +              os.path.join('WebCore', 'bindings', 'scripts', 'test'), # Input
dir
I would have put the big joins into little local vars first.

Looks OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.