[Webkit-unassigned] [Bug 38140] Initial support for HTMLMeterElement

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38140





--- Comment #14 from Yael <yael.aharon at nokia.com>  2010-04-26 19:42:03 PST ---
(In reply to comment #12)
> (From update of attachment 54352 [details])
> WebCore/html/HTMLMeterElement.cpp:89
>  +          value = 0;
> 
> Need to check NaN and Infinitiy.
> HTMLInputElement::parseToDoubleForNumber() implements the rules of HTML5. 
> Probably we should move parseToDoubelForNumber() to a common place and use it
> here too.
> I found the same issue in HTMLProgressElement.cpp.
> 
> 
> WebCore/html/HTMLMeterElement.cpp:95
>  +      setAttribute(valueAttr, String::number(isnan(value) ? 0 : value));
> 
> * We need to check infinity too.  So we should use !isfinite(value).
> * The HTML5 rule to convert a floating point number to a string is implemented
> in HTMLInputElement::serializeForNumberType().
> 
> 
> WebCore/html/HTMLMeterElement.cpp:102
>  +      double min = minString.toDouble(&ok);
> 
> Need to check NaN and Infinity.
> 
> 
> 
> LayoutTests/fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js:73
>  +  
> 
> We should have tests for NaN, Infinity.

Thank you for your comments Kent, I will look into moving the parsing code into
a common place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.