[Webkit-unassigned] [Bug 38155] Need to support more efficient dispatch of lightweight builtins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38155





--- Comment #3 from Oliver Hunt <oliver at apple.com>  2010-04-26 18:37:50 PST ---
(In reply to comment #2)
> Attachment 54369 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
> exit_code: 1
> JavaScriptCore/runtime/Lookup.h:80:  More than one command on the same line 
> [whitespace/newline] [4]
> JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:1707:
>  One or more unexpected \r (^M) found; better to use only a \n 
> [whitespace/carriage_return] [1]
> Suppressing further [whitespace/carriage_return] reports for this file.
> JavaScriptCore/jit/JSInterfaceJIT.h:38:  Code inside a namespace should not be
> indented.  [whitespace/indent] [4]
> JavaScriptCore/jit/SpecializedThunkJIT.h:37:  Code inside a namespace should
> not be indented.  [whitespace/indent] [4]
> JavaScriptCore/jit/ThunkGenerators.h:33:  Code inside a namespace should not be
> indented.  [whitespace/indent] [4]
> Total errors found: 20 in 27 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

style bot is wrong here -- code inside a namespace in a .h file should be
indented.  \r should be used in the vcproj, lookup.h has an assert as the first
command which is also allowed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.