[Webkit-unassigned] [Bug 37987] [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37987


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54251|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #23 from Adam Barth <abarth at webkit.org>  2010-04-26 16:16:55 PST ---
(From update of attachment 54251)
Ok.  The comments below are minor.

WebKitTools/Scripts/webkitpy/layout_tests/driver_test.py:62
 +      driver.stop()
To we need a finally to make sure we run this line of code?

WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:569
 +                  wdiff = wdiff.replace('##WDIFF_DEL##', '<span class=del>')
Yuck

WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:735
 +          browser_wrapper = os.environ.get("BROWSER_WRAPPER", None)
I think this "None" is superfluous.

WebKitTools/Scripts/webkitpy/layout_tests/port/base.py:740
 +              _log.error("BROWSER_WRAPPER will be removed any time after June
1st 2010 and your scripts will break.")
Yay.  Environment variables are evil.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.