[Webkit-unassigned] [Bug 38073] Clean up a few compiler warnings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38073


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #7 from Darin Adler <darin at apple.com>  2010-04-26 14:48:20 PST ---
(In reply to comment #6)
> The warnings are from MSVC

Good to know.

Are these particular MSVC warnings off for the Windows build (the one Apple
uses for Windows Safari)? Should we turn them on?

> but they are all fairly general.

I don't know what that means.

>  I agree that the
> TextMetrics rounding looks weird, but I'm not familiar enough with this code to
> guess whether or not it's an issue.

Generally I think it’s not good to silence a warning if the warning may be
pointed to a real problem. I am familiar enough to know that it might be an
issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.