[Webkit-unassigned] [Bug 38142] RegExp caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38142


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-04-26 14:43:55 PST ---
Attachment 54334 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']"
exit_code: 1
JavaScriptCore/runtime/RegExpCache.h:30:  #ifndef header guard has wrong style,
please use: RegExpCache_h  [build/header_guard] [5]
JavaScriptCore/runtime/RegExpCache.h:28:  Alphabetical sorting problem. 
[build/include_order] [4]
JavaScriptCore/runtime/RegExpCache.h:35:  Code inside a namespace should not be
indented.  [whitespace/indent] [4]
JavaScriptCore/runtime/RegExpCache.h:67:  Place brace on its own line for
function definitions.  [whitespace/braces] [4]
JavaScriptCore/runtime/RegExpCache.h:113:  One space before end of line
comments  [whitespace/comments] [5]
JavaScriptCore/runtime/RegExpCache.h:115:  Should have a space between // and
comment  [whitespace/comments] [4]
JavaScriptCore/runtime/RegExpCache.cpp:27:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
Total errors found: 7 in 9 files


If any of these errors are false positives, please file a bug against
check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.