[Webkit-unassigned] [Bug 24529] Add support in Web Inspector for examining/changing data for HTML5 offline-Web-applications (application cache)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24529





--- Comment #27 from Michael Nordman <michaeln at google.com>  2010-04-26 14:03:54 PST ---
39 class InspectorApplicationCacheAgent : public Noncopyable {
40 public:
41     InspectorApplicationCacheAgent(InspectorController* inspectorController,
InspectorFrontend* frontend);
42     ~InspectorApplicationCacheAgent();
43     
44     // Backend to Frontend
45     void didReceiveManifestResponse(unsigned long identifier, const
ResourceResponse&);
46     void updateApplicationCacheStatus(int status);
47     void updateNetworkState(bool isNowOnline);
48 
49     // From Frontend
50     // Nothing yet...
51 
52 private:
53     InspectorController* m_inspectorController;
54     InspectorFrontend* m_frontend;
55 };

Thanx for putting a .h file in there for this stuff.

What's the lifetime of the inspector controller/agents compared to the
frames/pages/documents that are being inspected? That would help me understand
what's going here quite a lot.

I think it may be confusing to co-mingle the display of resources loaded on
behalf of an update job running in the background with resources directly
loaded by the page. I hope you plan on visually differentiating them in the UI.
You've seperated out the call for the manifest resource having been loaded by
the update job, but you haven't separated out a call for other resources being
loaded by the update job. Having separate entry points into the 'inspector'
would make it easier to differentiate them further downstream in the resources
tab of the inspector. Have you considered adding another method for...
  void didReceiveResourceResponse(...)
... to this new class.

Also, update jobs actually can be running on behalf of several pages. Looks
like the plumbing you've got only routes the response info to one of those
pages, so if your looking at the 'right' inspector view, you'll see them and if
not you'll be out of luck i think. I'm not sure how to reconcile that with the
per-page inspector interface really, except maybe to push the response info to
all of the relevant inspectors.

The manifest url should probably show up somewhere in the UI very prominently.
Maybe that could be the label on the left-hand-side?

If there is no appcache, I think you can just have an empty APPLICATION CACHE
section on the left-hand-side. (I think that's in keeping with how some of the
others work when empty).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.