[Webkit-unassigned] [Bug 38132] Web Inspector: [Chromium] breakpoints are not preserved after reload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38132


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54321|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-04-26 13:17:06 PST ---
(From update of attachment 54321)
WebCore/inspector/front-end/Breakpoint.js:74
 +          return (this.url ? this.url : this.sourceID) + ":" + this.line;
It is not clear to me why this change is necessary. We'd like breakpoints to
point to exact scripts, while URL <-> sourceID mapping is external.


WebKit/chromium/src/js/DebuggerAgent.js:1100
 +          if (line * 1 == line)
if (parseInt(line) === line)



WebKit/chromium/src/js/DebuggerAgent.js:1101
 +              WebInspector.restoredBreakpoint(sourceID, scriptUrl,
devtools.DebuggerAgent.v8ToWwebkitLineNumber_(line * 1), true,
breakpoints[line].condition());
line * 1 -> parseInt(line)


I think you should call devtools.DebuggerAgent.prototype.addBreakpoint for
disabled breakpoints as well and populate the maps with the appropriate
BreakpointInfo. You would need to cut the control flow further so that disabled
breakpoint does not get into the VM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.