[Webkit-unassigned] [Bug 38048] Move _path_to_apache_config_file down to webkit.py

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 26 11:24:02 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38048


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54278|review?                     |review-
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-04-26 11:24:02 PST ---
(From update of attachment 54278)
This will break Chromium, since it does not inherit from webkit.py

Seems this should be a white-list for debian instead of a blacklist:
+            distro =
platform.linux_distribution(full_distribution_name=False)[0]
+            # FIXME: This is not going to scale. We should find a better way
to choose
+            # which config file to use, while still supporting the major
distributions
+            if distro in ["SuSE", "fedora", "redhat", "centos", "mandrake",
+                          "mandriva", "rocks", "slackware", "yellowdog",
"turbolinux"]:

Also, seems like we need a platform abstraction instead of a port in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list