[Webkit-unassigned] [Bug 35607] Allow building smoothly on win32 and win64 using GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35607


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53630|review?                     |review-
               Flag|                            |




--- Comment #59 from Adam Roben (aroben) <aroben at apple.com>  2010-04-26 06:33:18 PST ---
(From update of attachment 53630)
> +        *  WebCore/bridge/npapi.h: lparam and wparam are 64-bit on WIN64, uintptr_t keeps 32-bit compatibility

You should mention that this change matches Firefox. You could even reference
the bug you filed.

> +        *  WebCore/platform/Arena.h: fix pointer cast on win64

This comment is a little strange. You changed a typedef, but the comment talks
about a cast. I think you should clear this up.

It might also be worth mentioning that unsigned long is 64 bits on 64-bit Mac
builds, but only 32 bits on 64-bit Windows builds, while uintptr_t is 64 bits
on both.

Let's get these ChangeLog comments cleared up and then I'll r+ the patch.

Thanks for sticking with it!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.