[Webkit-unassigned] [Bug 38116] Media queries empty values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38116


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54281|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-04-26 05:33:10 PST ---
(From update of attachment 54281)

WebCore/ChangeLog:19
 +          corrected here. After landing this patch it will. The following
corrects the view
I dont think you should add things like "after landing this patch" in the
ChangeLog

WebCore/css/CSSValueKeywords.in:718
 +  windowed
This belongs to another patch. It is not related.

WebCore/css/MediaQueryExp.h:55
 +      bool valueParseError() const { return m_valueParseError; }
I do not like the name of the method. What about valueIsValid() or so?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.