[Webkit-unassigned] [Bug 37222] [WINCE] Port SharedBuffer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 26 02:44:38 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37222





--- Comment #5 from Patrick R. Gansterer <paroga at paroga.com>  2010-04-26 02:44:38 PST ---
(In reply to comment #3)
> It is possible, but I tried to follow the convention used in
> SharedBufferWin.cpp
I'd like to see the WinCE port directly in the Win32 port (where possible).
Maybe you can post a patch which only changes the Win32 version and remove the
ugly goto in this step by using somthing like:

fopen();
do {

  ftell()
  if (error)
    break;

  fread()

} while (0);

fclose();
return;


I think that it is more WebKit Style than your FileDescriptorHolder class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list