[Webkit-unassigned] [Bug 37977] [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37977





--- Comment #19 from Jeremy Moskovich <playmobil at google.com>  2010-04-25 08:53:23 PST ---
(From update of attachment 54241)
Ob-Disclaimer: I'm not a WebKit reviewer, a few general remarks:

WebCore/manual-tests/chromium/suggestions-popup-font-change.html:5
 +      <p>Do the following, the test passes if step 2 gets the expected
behavior</p>
nit: Perhaps something like:
Verify that font size in suggestion popup matches the corresponding input
field, test passes if step 2 matches expected behavior.

WebCore/manual-tests/chromium/suggestions-popup-font-change.html:9
 +            should be similar to the one in the text form</li>
nit - perhaps:
Verify that font size of text in suggestion popup is the same as in the
corresponding input form.

WebCore/manual-tests/chromium/suggestions-popup-font-change.html:10
 +          <li>3. Now delete the text from the input box and press Ctrl+.
Repeat the step 2.
nit - perhaps:
Delete contents of input box, press Cntrl/+ [Command/+ on Mac] to magnify the
page contents.
Repeat step 2. , text size should still match.

WebKit/chromium/ChangeLog:5
 +          [Chromium] Font size in suggestions popup menu should be correlated
with the font size of its text field.
Weird indent

WebKit/chromium/ChangeLog:3
 +       Reviewed by Adam Barth
nit: I always keep this as "Nobody" till I land the patch, the commit-queue
will automagically place the reviewer name here for you if you land it that
way.

WebKit/chromium/ChangeLog:6
 +      Test: WebCore/manual-tests/chromium/suggestions-popup-font-change.html
I wonder if it make sense to place this in WebCore/manual-tests since this
isn't really chromium specific?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.