[Webkit-unassigned] [Bug 38091] Build error without geolocation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 25 06:04:03 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38091


Ryuan Choi <bunhere at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54237|                            |review?
               Flag|                            |




--- Comment #1 from Ryuan Choi <bunhere at gmail.com>  2010-04-25 06:04:03 PST ---
Created an attachment (id=54237)
 --> (https://bugs.webkit.org/attachment.cgi?id=54237)
Fixing build break when Geolocation feature is disabled

Can I fix this build break?
I am newbie in webkit.org

My modification is as below,

Index: WebCore/page/Geolocation.cpp
===================================================================
--- WebCore/page/Geolocation.cpp        (revision 58227)
+++ WebCore/page/Geolocation.cpp        (working copy)
@@ -659,6 +659,8 @@ void Geolocation::stopUpdating()

 namespace WebCore {

+void Geolocation::clearWatch(int watchId) {}
+

I think clearWatch() should be added to #else of ENABLE(GEOLOCATION) in
Geolocation.cpp

Thank you,
Ryuan Choi

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list