[Webkit-unassigned] [Bug 38084] fast/events/touch has non-standard script test wrappers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38084


Ben Murdoch <benm at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |benm at google.com
                   |kit.org                     |
                 CC|                            |hausmann at webkit.org,
                   |                            |jamesr at chromium.org,
                   |                            |kim.gronholm at nomovok.com
             Blocks|                            |37830




--- Comment #1 from Ben Murdoch <benm at google.com>  2010-04-24 21:53:40 PST ---
I can look at this.

The tests you list above need to be run asynchronously (and so need
js-test-post-function.js) whereas the other touch tests run synchronously (so
use js-test-post.js). I propose refactoring the synchronous tests to be
asynchronous and and updating the TEMPLATE.html to include
js-test-post-function.js so that the tests you list have their wrappers
generated correctly.

Also of interest is bug 37830, where the current patch proposes rather than
including js-test-post-function.js at the top of TEMPLATE.html (i.e. so it is
parsed before the test runs) move it to the bottom of TEMPLATE.html and have
the test run onload. I prefer including the js file at the top but am open to
discussing the other alternatives.

Thanks, Ben

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.