[Webkit-unassigned] [Bug 38064] Refactoring: RenderBox::calcHeight() could look better

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38064





--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org>  2010-04-24 19:36:13 PST ---
I see. I've added the extra indentations for both the if condition you
mentioned and "else if" condition below. Or, it would be better just to make
them one line conditions? If so, I'll change them.

I didn't imagine these indentations are intentional. Actually, the style guide
has an example which doesn't have the extra indentation:

if (attr->name() == srcAttr
    || attr->name() == lowsrcAttr
    || (attr->name() == usemapAttr && attr->value().domString()[0] != '#'))
    return;

I hope we'll have a rule which clarifies this and fix this example. I have no
preference on this decision, but I want a consistent rule. Maybe, "we should
add 4 more indentations before conditional operators when we break line in
conditions" or something like this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.