[Webkit-unassigned] [Bug 37485] Make touch event support a RuntimeEnabledFeature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37485


Csaba Osztrogonac <ossy at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ossy at webkit.org




--- Comment #9 from Csaba Osztrogonac <ossy at webkit.org>  2010-04-24 02:57:16 PST ---
I tested the patch manually, but unfortunately I got a link-time error:

obj/debug/Document.o: In function
`WebCore::RuntimeEnabledFeatures::touchEnabled()':
../WebCore/bindings/generic/RuntimeEnabledFeatures.h:98: undefined reference to
`WebCore::RuntimeEnabledFeatures::isTouchEnabled'
collect2: ld returned 1 exit status
make[1]: *** [../lib/libQtWebKit.so.4.6.0] Error 1

The root of the problem is that the initialization of
RuntimeEnabledFeatures::isTouchEnabled (static member) can be found in
WebCore/bindings/generic/RuntimeEnabledFeatures.cpp, but this file isn't
builded for Qt port.

Adding RuntimeEnabledFeatures.cpp wouldn't solve the problem, because of the
following error:
../../../WebCore/bindings/generic/RuntimeEnabledFeatures.cpp: In static member
function 'static bool WebCore::RuntimeEnabledFeatures::webSocketEnabled()':
../../../WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:90: error:
'isAvailable' is not a member of 'WebCore::WebSocket'

WebSocket::isAvailable() is implemented in WebCore/websockets/WebSocket.cpp
guarded by #if USE(V8).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.