[Webkit-unassigned] [Bug 25882] User paths exposed on file drop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25882


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54175|review?                     |review-
               Flag|                            |




--- Comment #13 from Jian Li <jianli at chromium.org>  2010-04-23 13:37:10 PST ---
(From update of attachment 54175)
WebCore/platform/mac/ClipboardMac.h:89
 +      bool m_filenamesSetBySelf;
Might be better to name it as m_isFilenamesSetBySelf.

WebCore/platform/mac/ClipboardMac.mm:108
 +  static void addHTMLClipboardTypesForCocoaType(HashSet<String>& resultTypes,
const NSString *cocoaType, bool filenamesSetBySelf, NSPasteboard *pasteboard)
Since now we add only one type to resultTypes, how about changing the function
to return a type string, instead of passing resultTypes? The caller could then
add the type to the set.

WebCore/platform/mac/ClipboardMac.mm:152
 +      if (cocoaType == NSFilenamesPboardType)
You should say:
   if ( [cocoaType isEqualToString:NSFilenamesPboardType])

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.