[Webkit-unassigned] [Bug 37945] CMake buildsystem

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37945


Leandro Pereira <leandro at profusion.mobi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leandro at profusion.mobi




--- Comment #2 from Leandro Pereira <leandro at profusion.mobi>  2010-04-23 10:37:19 PST ---
(In reply to comment #1)
> Created an attachment (id=54140)
 --> (https://bugs.webkit.org/attachment.cgi?id=54140) [details]
> The patch 0.2
> 
> This new version of the patch should work now on linux with Gtk or Qt too.
>

I have some considerations:

1) Are you sure you need to list the headers in addition to the source files?
On the build system we've made for the EFL port, we didn't include them and it
worked like a charm.

2) Wouldn't it be nice to split the platform specifics into
CMakeListsPlatform.txt? This way the main CMakeLists.txt wont't get polluted,
with the drawback of having more files to touch in the event of certain changes
(but it'll be easier than today since it is still only one build system
format).

3) Auto-detecting the platform is nice, but we need to come up with a better
way to determine which build will be made (e.g. one might have both GTK+ and Qt
libraries and won't be able to build the Qt port -- unless the main
CMakeLists.txt file is edited). Perhaps a WEBKIT_PORT variable to be passed
passed to cmake?

In fact, I've made those changes to your previous patch. I am updating it to
take advantage of version 0.2 of your patch and I'll post here as soon as I
finish.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.